This repository was archived by the owner on Dec 8, 2023. It is now read-only.
feat: use math.prod instead of a for loop#27
Merged
morgante merged 3 commits intogetgrit:mainfrom Sep 23, 2023
vlopezferrando:math-prod-instead-of-for
Merged
feat: use math.prod instead of a for loop#27morgante merged 3 commits intogetgrit:mainfrom vlopezferrando:math-prod-instead-of-for
morgante merged 3 commits intogetgrit:mainfrom
vlopezferrando:math-prod-instead-of-for
Conversation
Contributor
Author
|
@morgante One question: I have seen that when using the pattern of matching an |
Contributor
Not easily. We mostly try to leave formatting changes like that out of scope and rely on formatters to clean things up after the Grit migration. |
Contributor
Author
|
Great, makes sense. |
morgante
suggested changes
Sep 19, 2023
.grit/patterns/math_prod.md
Outdated
| } | ||
| } | ||
|
|
||
| `$for` where { |
Contributor
There was a problem hiding this comment.
This will match anything and then restrict it, which ends up being much worse for performance. It's better to hoist the for_statement up as the main thing we're matching against.
morgante
approved these changes
Sep 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on #25.
This pattern transforms a loop that computes the product of a list of numbers into a call to
math.prod(introduced in Python 3.8).